From c169a5e025e81d1043ac9c7afc2f999f0607cd78 Mon Sep 17 00:00:00 2001 From: "Ralf W. Grosse-Kunstleve" Date: Thu, 22 Apr 2021 06:26:39 -0700 Subject: [PATCH] Adding link to PR #2644. Pushing directly for this minor addition to the documentation. --- README_smart_holder.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README_smart_holder.rst b/README_smart_holder.rst index 75bf6e8023..03f921698f 100644 --- a/README_smart_holder.rst +++ b/README_smart_holder.rst @@ -280,7 +280,9 @@ but not the more general holder mismatch issue. — Unfortunately the existing pybind11 internals do not track holder runtime type information, therefore the holder mismatch issue cannot be solved in a fashion that would allow an incremental transition, which is the whole point of the Conservative -mode. Please proceed with caution. +mode. Please proceed with caution. (See `PR #2644 +`_ for background, which is +labeled with "abi break".) Another pitfall worth pointing out specifically, although it follows from the previous: mixing base and derived classes between Classic and