From eb8069fc2521dfc217bb5dcc18f749977b059f24 Mon Sep 17 00:00:00 2001 From: Joachim Jablon Date: Mon, 28 Aug 2023 10:32:38 +0200 Subject: [PATCH] drop "incremental" version part, keep only minor and major --- .github/workflows/release.yml | 13 +++---------- README.md | 14 +++++++------- 2 files changed, 10 insertions(+), 17 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 7e054397..793289c5 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -49,23 +49,16 @@ jobs: - name: Apply new tags run: | git fetch --tags origin - current="$(git describe --tags --abbrev=0 --match 'v*.*.*')" - should_bump_minor=$(pipx run conventional list-commits --from-last-tag --parse | jq --slurp 'any(.[]; .data.subject.breaking == "!")') + current="$(git describe --tags --abbrev=0 --match 'v*.*')" major="$(echo $current | cut -d. -f1)" minor="$(echo $current | cut -d. -f2)" - patch="$(echo $current | cut -d. -f3)" git tag -f ${major} git push -f origin ${major} # Major releases will be released manually. - if [ "${should_bump_minor}" = "true" ]; then - minor=$((minor + 1)) - new_tag="${major}.${minor}.0" - else - patch=$((patch + 1)) - new_tag="${major}.${minor}.${patch}" - fi + patch=$((patch + 1)) + new_tag="${major}.${minor}" gh release create ${new_tag} --generate-notes diff --git a/README.md b/README.md index 9daca999..70dd920a 100644 --- a/README.md +++ b/README.md @@ -387,13 +387,13 @@ coverage (percentage) of the whole project from the PR build: ## Pinning -On the examples above, the version was set to the tag `v3`. Pinning to -a specific version (`v3.1.0` for example) would make the action more -reproducible, though you'd have to update it regularly (e.g. using Dependabot). -You can also pin a commit hash if you want to be 100% sure of what you run, -given that tags are mutable. -You can also decide to pin to main, if you're ok with the action maybe breaking -when (if) we release a v4. +On the examples above, the version was set to the tag `v3`. Pinning to a major version +will give you the latest release on this version. (Note that we release everytime after +a PR is merged). Pinning to a specific version (`v3.1` for example) would make the +action more reproducible, though you'd have to update it regularly (e.g. using +Dependabot). You can also pin a commit hash if you want to be 100% sure of what you run, +given that tags are mutable. Finally, You can also decide to pin to main, if you're ok +with the action maybe breaking when (if) we release a v4. ## Note on the state of this action