Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tests #47

Open
digitall-it opened this issue Jul 13, 2024 · 1 comment
Open

Missing tests #47

digitall-it opened this issue Jul 13, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@digitall-it
Copy link

digitall-it commented Jul 13, 2024

It would be nice if this package had some tests and start listing which ones may be in the scope. For example, testing features of the underlying Spatie package or Filament features could be meaningless. Instead, things like checking if the field translations are respected, or if the restoration feature actually does the job, may be interesting test cases worth looking after.

@pxlrbt pxlrbt added enhancement New feature or request help wanted Extra attention is needed labels Jul 13, 2024
@pxlrbt
Copy link
Owner

pxlrbt commented Jul 19, 2024

Definitely interesting, but I currently don't have the time to implement this myself. I'd be happy to accept a good PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants