Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop overwriting the routes.yaml file #24

Open
cprice404 opened this issue Dec 6, 2012 · 2 comments
Open

Stop overwriting the routes.yaml file #24

cprice404 opened this issue Dec 6, 2012 · 2 comments
Labels

Comments

@cprice404
Copy link

The current implementation of this module overwrite routes.yaml with the exact settings needed by PuppetDB. If a user already has a routes.yaml file that is managing other things besides the the facts terminus, their settings will be blown away.

We should handle this more gracefully. It ought to be pretty simple to put together a yaml module that had a resource type for dealing with an individual yaml setting. If we did that, then the PuppetDB module could use that to set only the relevant settings without overriding any existing settings.

@branan
Copy link

branan commented Dec 6, 2012

I think that a type which is specific to routes.yaml would be more user-friendly than a generic yaml module.

@cprice404
Copy link
Author

True. The former could be built on top of the latter, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants