Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dotnet templates to net8.0 #849

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Update dotnet templates to net8.0 #849

merged 3 commits into from
Nov 12, 2024

Conversation

smithrobs
Copy link
Contributor

Addresses #690

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

PR is now waiting for a maintainer to run the template acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-templates on the PR

@smithrobs smithrobs marked this pull request as draft November 1, 2024 21:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

PR is now waiting for a maintainer to run the template acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-templates on the PR

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

PR is now waiting for a maintainer to run the template acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-templates on the PR

@smithrobs smithrobs marked this pull request as ready for review November 1, 2024 21:48
@justinvp
Copy link
Member

justinvp commented Nov 8, 2024

/run-templates

@justinvp
Copy link
Member

justinvp commented Nov 8, 2024 •
edited
Loading

@smithrobs, are you able to clone this repo directly and push these changes in a branch, and then open a PR from that branch into master? (Rather than doing it from a fork of the repo). That should let the tests run.

I'm not sure what's going on with the /run-templates command.

@justinvp justinvp mentioned this pull request Nov 8, 2024
Merged
@thoward thoward merged commit cd960fc into pulumi:master Nov 12, 2024
3 of 6 checks passed
@smithrobs smithrobs deleted the net80 branch November 12, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smithrobs @justinvp @thoward