Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure Classic to v6 #839

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Update Azure Classic to v6 #839

merged 2 commits into from
Oct 2, 2024

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Oct 2, 2024 •
edited
Loading

  • Bump major version in dependencies.
  • Add required subscriptionId config

Part of pulumi/pulumi-azure#2336

@danielrbradley
Update Azure Classic to v6
4597af3 
Add required subscriptionId config
@danielrbradley danielrbradley self-assigned this Oct 2, 2024
@danielrbradley danielrbradley requested review from thomas11 and a team October 2, 2024 09:01
thomas11
thomas11 reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about azure-classic-visualbasic and azure-classic-yaml? The latter needs subscriptionId, too, doesn't it?

@danielrbradley
Copy link
Member Author

What about azure-classic-visualbasic and azure-classic-yaml? The latter needs subscriptionId, too, doesn't it?

Good spot .. pushed. Not sure why my search didn't show them up.

@danielrbradley danielrbradley merged commit 39e11d6 into master Oct 2, 2024
6 checks passed
@danielrbradley danielrbradley deleted the danielrbradley/azure-classic-v6 branch October 2, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas11 thomas11 thomas11 approved these changes

Assignees

@danielrbradley danielrbradley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielrbradley @thomas11