Workflow failure: Run Acceptance Tests on main

[pulumi-bot]

Workflow Failure

Run Acceptance Tests on main has failed. See the list of failures below:

• 2024-09-18T10:06:40.000Z

[mjeffryes]

Looks like the property tests may have caught an edge case:

--- FAIL: TestRapidDeepEqual (0.17s)
    putil_test.go:30: [rapid] OK, passed 100 tests (113.254702ms)
    putil_test.go:37: [rapid] failed after 33 tests: 
        	Error Trace:	/home/runner/work/pulumi-go-provider/pulumi-go-provider/putil/putil_test.go:42
        	            				/home/runner/go/pkg/mod/pgregory.net/[email protected]/engine.go:368
        	            				/home/runner/go/pkg/mod/pgregory.net/[email protected]/engine.go:268
        	            				/home/runner/go/pkg/mod/pgregory.net/[email protected]/engine.go:191
        	            				/home/runner/go/pkg/mod/pgregory.net/[email protected]/engine.go:118
        	            				/home/runner/work/pulumi-go-provider/pulumi-go-provider/putil/putil_test.go:37
        	Error:      	Should be false
        	Test:       	TestRapidDeepEqual
        
        To reproduce, specify -run="TestRapidDeepEqual" -rapid.failfile="testdata/rapid/TestRapidDeepEqual/TestRapidDeepEqual-20240918100423-13963.fail" (or -rapid.seed=949552452592648908)
        Failed test output:
    putil_test.go:41: [rapid] draw distinct: []resource.PropertyValue{resource.PropertyValue{V:resource.Output{Element:resource.PropertyValue{V:resource.Output{Element:resource.PropertyValue{V:interface {}(nil)}, Known:false, Secret:false, Dependencies:[]urn.URN{"", "&\n[?", "\x7f=&\u202c\x7fᾩ:AȺ~", "!aAὂ̥\ue007~a\x01?۵%", "*\"\u2005\ue005-a=\v\u2008䍨~ᶞ٣_"}}}, Known:true, Secret:true, Dependencies:[]urn.URN{"", "A#@\u008b%\x00$\u202e\U000e006a|ᛮ<:ፘ.᭴ो〦\U000fd7da!𞥋\v%\x7fڌ֝[A{ॊⅣ\nA1|_\u3000%a", "%"}}}, resource.PropertyValue{V:resource.Output{Element:resource.PropertyValue{V:interface {}(nil)}, Known:false, Secret:true, Dependencies:[]urn.URN{"", "̿A#꙲ .\u2029\u1680~;,*\ue000֍\ue001º`a貦", "_¦?!", "\u2007�", ";\U000e003e\r𞥋\\𞓶\x02٦Lj$=1𝛜ᾫ?", "{Aັ\\Dž", "̆aLjⅺ*~"}}}}
    putil_test.go:42: 
        	Error Trace:	/home/runner/work/pulumi-go-provider/pulumi-go-provider/putil/putil_test.go:42
        	            				/home/runner/go/pkg/mod/pgregory.net/[email protected]/engine.go:368
        	            				/home/runner/go/pkg/mod/pgregory.net/[email protected]/engine.go:232
        	            				/home/runner/go/pkg/mod/pgregory.net/[email protected]/engine.go:118
        	            				/home/runner/work/pulumi-go-provider/pulumi-go-provider/putil/putil_test.go:37
        	Error:      	Should be false
        	Test:       	TestRapidDeepEqual
FAIL

[mjeffryes]

Formatting the failing inputs to make it a little easier to read:

[]resource.PropertyValue{
  resource.PropertyValue{
    V:resource.Output{
      Element:resource.PropertyValue{
        V:resource.Output{
          Element:resource.PropertyValue{ V:interface{ }(nil) },
          Known:false, 
          Secret:false, 
          Dependencies:[]urn.URN{
            "", "&\n[?", "\x7f=&\u202c\x7fᾩ:AȺ~", "!aAὂ̥\ue007~a\x01?۵%", "*\"\u2005\ue005-a=\v\u2008䍨~ᶞ٣_"
          }
        }
      },
      Known:true,
      Secret:true, 
      Dependencies:[]urn.URN{
        "", "A#@\u008b%\x00$\u202e\U000e006a|ᛮ<:ፘ.᭴ो〦\U000fd7da!𞥋\v%\x7fڌ֝[A{ॊⅣ\nA1|_\u3000%a", "%"
      }
    }
  },
  resource.PropertyValue{
    V:resource.Output{
      Element:resource.PropertyValue{
        V:interface { } (nil)
      },
      Known:false,
      Secret:true,
      Dependencies:[]urn.URN{
        "", "̿A#꙲ .\u2029\u1680~;,*\ue000֍\ue001º`a貦", "_¦?!", "\u2007�", ";\U000e003e\r𞥋\\𞓶\x02٦Lj$=1𝛜ᾫ?", "{Aັ\\Dž", "̆aLjⅺ*~"
      }
    }
  }
}

The test is supposed to be checking that the deepEqual function returns false for two distinct PropertyValue instances, but for some reason these returned equal

[iwahbe]

It's a real edge case in the test, but the values are actually equal. The nested resource.Outputs throws off the test, but semantically they are equal.

[pulumi-bot]

This issue has been addressed in PR #275 and shipped in release v0.23.0.