Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on provider authors when they use pulumi's Asset type #243

Open
thomas11 opened this issue Jun 13, 2024 · 0 comments
Open

Error on provider authors when they use pulumi's Asset type #243

thomas11 opened this issue Jun 13, 2024 · 0 comments
Labels
1.0.0-blocker An issue that must be resolved before 1.0.0 kind/enhancement Improvements or new features

Comments

@thomas11
Copy link
Contributor

As discussed in #237, the core Asset doesn't roundtrip correctly, so we introduced types.AssetOrArchive in this provider.

Nothing prevents a provider author from still using Asset, though. We should at least print a warning at schemagen time when they do that.

I attempted this in a simple way in Warn about using the core Asset and Archive types but that yielded false positive warnings. The local.Command has Assets as an output property which is ok but triggered the warning.

@thomas11 thomas11 added the kind/enhancement Improvements or new features label Jun 13, 2024
@iwahbe iwahbe added the 1.0.0-blocker An issue that must be resolved before 1.0.0 label Aug 5, 2024
@iwahbe iwahbe changed the title Warn provider authors when they use pulumi's Asset type Error on provider authors when they use pulumi's Asset type Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0-blocker An issue that must be resolved before 1.0.0 kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants