Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on pulumi:"secret" #192

Open
blampe opened this issue Feb 12, 2024 · 0 comments
Open

Error on pulumi:"secret" #192

blampe opened this issue Feb 12, 2024 · 0 comments
Labels
1.0.0-blocker An issue that must be resolved before 1.0.0 kind/enhancement Improvements or new features

Comments

@blampe
Copy link
Contributor

blampe commented Feb 12, 2024

Several times I've accidentally tagged a field as something like pulumi:"optional,secret" instead of pulumi:"optional" provider:"secret". This generates SDKs well enough, but once you try populating this it will panic:

panic: fatal: An assertion has failed: Unrecognized tagpart on field Foo.Token: secret

We should catch this an either error, or automatically apply the provider tag.

More generally, the pulumi/provider distinction feels like an abstraction is leaking. It would be most user-friendly to only have to worry about pulumi:"..." tags.
@blampe blampe added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Feb 12, 2024
@mjeffryes mjeffryes removed the needs-triage Needs attention from the triage team label Feb 12, 2024
@iwahbe iwahbe added the 1.0.0-blocker An issue that must be resolved before 1.0.0 label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0.0-blocker An issue that must be resolved before 1.0.0 kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blampe @mjeffryes @iwahbe