Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that diff: ignoreChanges behavior is correct #103

Open
iwahbe opened this issue Jul 25, 2023 · 0 comments
Open

Ensure that diff: ignoreChanges behavior is correct #103

iwahbe opened this issue Jul 25, 2023 · 0 comments
Labels
help-wanted We'd love your contributions on this issue kind/engineering Work that is not visible to an external user

Comments

@iwahbe
Copy link
Member

iwahbe commented Jul 25, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

We currently undo the "ignored" changes for Diff and Update. We need to confirm that this works as intended.

I have been told that the engine already handles this. We need to confirm if this code is necessary. If it is, we should put it under test. If not, we need to document the behavior of the engine and remove the unused code.

Affected area/feature

@iwahbe iwahbe added kind/engineering Work that is not visible to an external user good-first-issue Start here if you'd like to start contributing to Pulumi labels Jul 25, 2023
@iwahbe iwahbe added help-wanted We'd love your contributions on this issue and removed good-first-issue Start here if you'd like to start contributing to Pulumi labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted We'd love your contributions on this issue kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

1 participant