Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Valkey engine to Elasticache. #4620

Closed
j-fulbright opened this issue Oct 9, 2024 · 6 comments
Closed

Add support for Valkey engine to Elasticache. #4620

j-fulbright opened this issue Oct 9, 2024 · 6 comments
Assignees
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@j-fulbright
Copy link

Describe what happened

AWS has made a new engine for Elasticache available called Valkey. It appears all that really needs to happen is engine change.

Sample program

n/a

Log output

No response

Affected Resource(s)

No response

Output of pulumi about

n/a

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@j-fulbright j-fulbright added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Oct 9, 2024
@corymhall
Copy link
Contributor

Linking the upstream issue hashicorp/terraform-provider-aws#39641. Once this is added in the upstream provider we would release support in the next release.

@corymhall corymhall added awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). and removed needs-triage Needs attention from the triage team labels Oct 10, 2024
@aliismayilov
Copy link

The upstream issue is resolved.

@steveteuber
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider.
Pulumi AWS v6.57.0 is released as well but it doesn't support this functionality yet?

Diagnostics:
  aws:elasticache:Cluster (cluster):
    error: aws:elasticache/cluster:Cluster resource 'cluster' has a problem: expected engine to be one of ["memcached" "redis"], got valkey. Examine values at 'cluster.engine'.

@flostadler
Copy link
Contributor

Currently the CreateCacheCluster API on the AWS side does not support valkey.
The corresponding upstream issue is currently blocked on that: hashicorp/terraform-provider-aws#39905

You can start using Valkey with the ReplicationGroup resource: https://www.pulumi.com/registry/packages/aws/api-docs/elasticache/replicationgroup/

You can even deploy a single-primary cluster with the ReplicationGroup resource

@flostadler
Copy link
Contributor

For reference, this is how you'd deploy a single node cluster using the ReplicationGroup resource:

import * as aws from "@pulumi/aws";

const valkey = new aws.elasticache.ReplicationGroup("valkey-test", {
    description: "valkey cluster",
    nodeType: "cache.m4.large",
    numCacheClusters: 1,
    engine: "valkey",
    port: 6379,
});

@flostadler flostadler self-assigned this Nov 14, 2024
@flostadler flostadler added the resolution/fixed This issue was fixed label Nov 14, 2024
@flostadler
Copy link
Contributor

I opened #4771 to track Valkey support for the CacheCluster resource.

I'm going to close this issue for now because Valkey is supported according to AWS current API capabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

5 participants