Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state machine principal #2786

Closed
nickroberts opened this issue Sep 6, 2023 · 1 comment · Fixed by #2789
Closed

Add state machine principal #2786

nickroberts opened this issue Sep 6, 2023 · 1 comment · Fixed by #2789
Assignees
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi kind/enhancement Improvements or new features language/javascript resolution/fixed This issue was fixed
Milestone

Comments

@nickroberts
Copy link
Contributor

nickroberts commented Sep 6, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Add states.amazonaws.com service principal to principal constants.

Affected area/feature

Add something like this:

/**
  * Service Principal for Amazon State Machines
  */
export const StateMachineServicePrincipal: Principal = {Service: "states.amazonaws.com"};

to here: https://github.com/pulumi/pulumi-aws/blob/master/sdk/nodejs/iam/principals.ts

@nickroberts nickroberts added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Sep 6, 2023
@mikhailshilkov
Copy link
Member

mikhailshilkov commented Sep 7, 2023

Thank you for opening this issue @nickroberts! Do you want to try to open a PR for it? It should be fairly straightforward and comparable to #1494 (and no need for manual changelog anymore)

@mikhailshilkov mikhailshilkov added language/javascript good-first-issue Start here if you'd like to start contributing to Pulumi and removed needs-triage Needs attention from the triage team labels Sep 7, 2023
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 7, 2023
@mikhailshilkov mikhailshilkov added this to the 0.94 milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi kind/enhancement Improvements or new features language/javascript resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants