Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing an alpha version does not tag the SDK #2704

Open
t0yv0 opened this issue Aug 21, 2023 · 4 comments
Open

Releasing an alpha version does not tag the SDK #2704

t0yv0 opened this issue Aug 21, 2023 · 4 comments
Labels
6.0 kind/engineering Work that is not visible to an external user

Comments

@t0yv0
Copy link
Member

t0yv0 commented Aug 21, 2023

What happened?

Following a bot-initiated alpha release:

@release-bot release pulumi-aws v6.0.2-alpha.1

Observing that sdk/v6.0.2-alpha.1 tag has not been added to the repository. Therefore the Go SDK is not released.

The job had a Java publishing failure but that seems like it should be unrelated.

Expected Behavior

Releasing an alpha releases the Go SDK.

Steps to reproduce

N/A

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added kind/engineering Work that is not visible to an external user 6.0 labels Aug 21, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Aug 21, 2023

I will add the tag manually for now.

@mnlumi
Copy link

mnlumi commented Aug 28, 2023

@t0yv0 what else needs to happen here going forward?

@t0yv0
Copy link
Member Author

t0yv0 commented Aug 28, 2023

After the repo transitions to ci-mgmt workflows we can move it to ci-mgmt; something is not quite reliable with the workflow generation. Looks like sdk/v6.0.2 got created so maybe there's something like Java publishing failure impeding the Go publishing failure.

@t0yv0
Copy link
Member Author

t0yv0 commented Aug 28, 2023

So in fact

release.yml include this:

  tag_sdk:
    name: tag_sdk
    needs: publish_sdk
    runs-on: ubuntu-latest
    steps:
    - name: Checkout Repo
      uses: actions/checkout@v3
    - name: Install pulumictl
      uses: jaxxstorm/[email protected]
      with:
        repo: pulumi/pulumictl
    - name: Add SDK version tag
      run: git tag sdk/v$(pulumictl get version --language generic) && git push origin
        sdk/v$(pulumictl get version --language generic)

But it does not apply to alpha pre-releases, so that's probably what's wrong here. We should fix it so we can tag alpha releases seamlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.0 kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

2 participants