Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update local examples to v6 #2674

Closed
Tracked by #2539
mnlumi opened this issue Aug 7, 2023 · 4 comments
Closed
Tracked by #2539

Update local examples to v6 #2674

mnlumi opened this issue Aug 7, 2023 · 4 comments
Assignees
@mnlumi
Labels
6.0 kind/task Work that's part of an ongoing epic resolution/fixed This issue was fixed
Milestone
0.93

Comments

@mnlumi
Copy link

mnlumi commented Aug 7, 2023 •
edited
Loading

Update all examples and tests within pulumi-aws repo to use v6.

https://github.com/pulumi/pulumi-aws/tree/master/examples
https://github.com/pulumi/pulumi-aws/blob/master/examples/examples_go_test.go#L18
@mnlumi mnlumi mentioned this issue Aug 7, 2023
Closed
34 tasks
@mnlumi mnlumi added kind/task Work that's part of an ongoing epic 6.0 labels Aug 7, 2023
@t0yv0
Copy link
Member

t0yv0 commented Aug 7, 2023

https://github.com/pulumi/pulumi-aws/blob/e5e6ddd926f63895c34342d8f19a01b771942674/examples/examples_go_test.go#L18-#L18 looks like Ramon updated this one already

@t0yv0
Copy link
Member

t0yv0 commented Aug 7, 2023

Just giving it a quick scan again, I think the effect is mostly cosmetic that is things like https://github.com/pulumi/pulumi-aws/blob/e5e6ddd926f63895c34342d8f19a01b771942674/examples/webserver-go/go.mod#L6-#L6 aren't great for users to discover, but these dependencies get updated on-the-fly by the CI to the current in-source version so I'm not worried about testing the wrong software in CI, just a nice cleanup task.

@mikhailshilkov mikhailshilkov added this to the 0.93 milestone Aug 11, 2023
@mnlumi
Copy link
Author

mnlumi commented Aug 23, 2023

Current V5 references:

@mnlumi
Copy link
Author

mnlumi commented Aug 25, 2023

Fixed by #2716

@mnlumi mnlumi added the resolution/fixed This issue was fixed label Aug 25, 2023
@mnlumi mnlumi closed this as completed Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnlumi mnlumi

Labels
6.0 kind/task Work that's part of an ongoing epic resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.93
Development

No branches or pull requests
3 participants
@t0yv0 @mikhailshilkov @mnlumi