-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AutoName for Plugin Framework based resources #2661
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Verified on aws:route53/cidrCollection:CidrCollection |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits, but otherwise looks good.
Hmm, is this a flake or something more serious? Trying again. |
No it's persistent. Will investigate tomorrow. |
@t0yv0 Could this be related to https://pulumi.slack.com/archives/CBUP505U7/p1691101512583479? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Indeed, I think the test failures were for an unrelated reason (org tokens). I reran and it's green now. |
thank you! |
This is on top of pulumi/pulumi-terraform-bridge#1321
Fixes #2644
Auto-naming is now supported for PF so besides fixing the warning for requested resources it rolls it out to all of these:
TODOs: