Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AutoName for Plugin Framework based resources #2661

Merged
merged 8 commits into from
Aug 4, 2023
Merged

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Aug 1, 2023

This is on top of pulumi/pulumi-terraform-bridge#1321

Fixes #2644

Auto-naming is now supported for PF so besides fixing the warning for requested resources it rolls it out to all of these:

  • resource:aws_appconfig_environment
  • resource:aws_auditmanager_assessment
  • resource:aws_auditmanager_assessment_report
  • resource:aws_auditmanager_control
  • resource:aws_auditmanager_framework
  • resource:aws_cognito_user_pool_client
  • resource:aws_opensearchserverless_access_policy
  • resource:aws_opensearchserverless_collection
  • resource:aws_opensearchserverless_security_config
  • resource:aws_opensearchserverless_security_policy
  • resource:aws_opensearchserverless_vpc_endpoint
  • resource:aws_quicksight_vpc_connection
  • resource:aws_resourceexplorer2_view
  • resource:aws_route53_cidr_collection
  • resource:aws_route53_cidr_location
  • resource:aws_simpledb_domain

TODOs:

  • release underlying bridge support
  • verify end to end on one of these resources
  • rebuild schema and SDKs

@t0yv0

This comment was marked as outdated.

@t0yv0 t0yv0 requested review from iwahbe and a team August 2, 2023 17:28
@t0yv0
Copy link
Member Author

t0yv0 commented Aug 2, 2023

Verified on aws:route53/cidrCollection:CidrCollection

@github-actions

This comment was marked as outdated.

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, but otherwise looks good.

examples/plugin-framework/Pulumi.yaml Outdated Show resolved Hide resolved
provider/go.mod Outdated Show resolved Hide resolved
@t0yv0 t0yv0 requested a review from iwahbe August 3, 2023 21:02
@t0yv0 t0yv0 changed the title Support AutoName for PF Support AutoName for Plugin Framework based resources Aug 3, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Aug 3, 2023

command.go:83: Invoke '/opt/hostedtoolcache/pulumi/3.76.1/x64/pulumi login --cloud-url https://api.pulumi-staging.io/' failed: exit status 255
  Logging in using access token from PULUMI_ACCESS_TOKEN
  error: problem logging in: invalid access token

Hmm, is this a flake or something more serious? Trying again.

@t0yv0
Copy link
Member Author

t0yv0 commented Aug 3, 2023

No it's persistent. Will investigate tomorrow.

@iwahbe
Copy link
Member

iwahbe commented Aug 4, 2023

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikhailshilkov
Copy link
Member

Indeed, I think the test failures were for an unrelated reason (org tokens). I reran and it's green now.

@t0yv0
Copy link
Member Author

t0yv0 commented Aug 4, 2023

thank you!

@t0yv0 t0yv0 merged commit 83a290d into v6 Aug 4, 2023
15 checks passed
@t0yv0 t0yv0 deleted the t0yv0/v6-autonaming branch August 4, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants