Move field roleInstance from Function to CallbackFunction
#2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2639 This actually makes the mixin more self-contained, since we previously added a field to a normal pulumi resource, making TS's `lambda.Function` different then Go's `lambda.Function`. With this change, `lambda.Function` is the same in all languages.
thomas11
reviewed
Jul 26, 2023
`serverless.Function` has been deprecated in favor of `lambda.CallbackFunction` since 2018 (#327). Since it depends on the removed functionality, I have bundled its removal.
iwahbe
force-pushed
the
iwahbe/2639/move-roleInstance-from-function-to-callbackFunction
branch
from
2af82de
to
2c09c53
Compare
It should be an easy update. |
thomas11
approved these changes
Jul 26, 2023
iwahbe
deleted the
iwahbe/2639/move-roleInstance-from-function-to-callbackFunction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2639
This actually makes the mixin more self-contained, since we previously added a field to a normal pulumi resource, making TS's
lambda.Functiondifferent then Go'slambda.Function. With this change,lambda.Functionis the same in all languages.2c09c53:
serverless.Functionhas been deprecated in favor oflambda.CallbackFunctionsince 2018 (#327). Since it depends on the removed functionality, I have bundled its removal.