Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, there is a limit to the size of content that is accepted to be retrieved via live api #532

Open
goosemania opened this issue Jan 12, 2022 · 1 comment · May be fixed by #1701
Assignees
Labels

Comments

@goosemania
Copy link
Member

Podman client seems to have I/O limits for different content types, e.g. signatures.
It might make sense to have similar things implemented in Pulp, e.g. to protect pulp2pulp sync case when the number of signatures on the main pulp grows significantly. Usually that many signatures are not needed and is a sign that there are some old ones which are no longer needed. Allowing it to grow indefinitely may affect pulp2pulp sync performance.

@lubosmj
Copy link
Member

lubosmj commented Jul 1, 2024

There is a chance that clients can flood and freeze our API with a huge monolithic upload. We may want to introduce sane thresholds for uploads. The I/O limits referenced by @goosemania are defined at https://github.com/containers/image/blob/8d792a4a930c36ae3228061531cca0958ba4fe0a/internal/iolimits/iolimits.go#L4.

@git-hyagi git-hyagi self-assigned this Jul 10, 2024
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Jul 12, 2024
@git-hyagi git-hyagi linked a pull request Jul 12, 2024 that will close this issue
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Aug 26, 2024
Adds limit to the size of manifests and signatures as a safeguard
to avoid DDoS attack during sync operations.
To also prevent this during image upload, this commit configures a
`client_max_body_size` for manifests and signatures Nginx endpoints.

closes: pulp#532
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Aug 26, 2024
Adds limit to the size of manifests and signatures as a safeguard
to avoid DDoS attack during sync operations.
To also prevent this during image upload, this commit configures a
`client_max_body_size` for manifests and signatures Nginx endpoints.

closes: pulp#532
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Sep 2, 2024
Adds limit to the size of manifests and signatures as a safeguard
to avoid DDoS attack during sync operations.
To also prevent this during image upload, this commit configures a
`client_max_body_size` for manifests and signatures Nginx endpoints.

closes: pulp#532
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Sep 11, 2024
Adds a limit to the size of manifests and signatures as a safeguard
to avoid DDoS attack during sync and upload operations.
To also prevent this during image upload, this commit configures a
`client_max_body_size` for manifests and signatures Nginx endpoints.

closes: pulp#532
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Sep 11, 2024
Adds a limit to the size of manifests and signatures as a safeguard
to avoid DDoS attack during sync and upload operations.
To also prevent this during image upload, this commit configures a
`client_max_body_size` for manifests and signatures Nginx endpoints.

closes: pulp#532
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Sep 12, 2024
Adds new settings to limit the size of manifests and signatures as a safeguard
to avoid DDoS attack during sync and upload operations.
To also prevent this during image upload, this commit configures a
`client_max_body_size` for manifests and signatures Nginx endpoints.
Modify the blob upload to read the layers in chunks.

closes: pulp#532
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Sep 18, 2024
Adds new settings to limit the size of manifests and signatures as a safeguard
to avoid DDoS attack during sync and upload operations.
To also prevent this during image upload, this commit configures a
`client_max_body_size` for manifests and signatures Nginx endpoints.
Modify the blob upload to read the layers in chunks.

closes: pulp#532
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Sep 18, 2024
Adds new settings to limit the size of manifests and signatures as a safeguard
to avoid DDoS attack during sync and upload operations.
To also prevent this during image upload, this commit configures a
`client_max_body_size` for manifests and signatures Nginx endpoints.
Modify the blob upload to read the layers in chunks.

closes: pulp#532
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Sep 18, 2024
Adds new settings to limit the size of manifests and signatures as a safeguard
to avoid DDoS attack during sync and upload operations.
To also prevent this during image upload, this commit configures a
`client_max_body_size` for manifests and signatures Nginx endpoints.
Modify the blob upload to read the layers in chunks.

closes: pulp#532
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Oct 4, 2024
Adds new settings to limit the size of manifests and signatures as a safeguard
to avoid DDoS attack during sync and upload operations.
Modify the blob upload to read the layers in chunks.

closes: pulp#532
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Oct 14, 2024
Adds new settings to limit the size of manifests and signatures as a safeguard
to avoid DDoS attack during sync and upload operations.
Modify the blob upload to read the layers in chunks.

closes: pulp#532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants