Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is dependence condition missing in compose.folders.yml for pulp_web service #574

Open
xm1234567 opened this issue Jan 10, 2024 · 3 comments
Assignees

Comments

@xm1234567
Copy link

Version
pulp/pulp-minimal latest f89cae78c76a
pulp/pulp-web latest 69a0e8f150cc

Describe the bug
I tired compose.folders.yml, got the following:

[xxx@xxx compose]$ docker compose -f compose.folders.yml up
validating /home/xniu/pulp-oci-images/images/compose/compose.folders.yml: services.pulp_web.depends_on.pulp_api must be a mapping

I changed a bit the compose.folders.yml, added the two condition statements for pulp_api and pulp_content, then the above problem gone:

  pulp_web:
    image: "pulp/pulp-web:latest"
    command: ['/usr/bin/nginx.sh']
    depends_on:
      pulp_api:
        condition: service_healthy
      pulp_content:
        condition: service_healthy

To Reproduce
just run docker compose -f compose.folders.yml up

Expected behavior
docker compose CLI should be able to run.

@mdellweg
Copy link
Member

I'm certain, both versions are allowed per the docker compose docs (or at least were).
But the change you made sounds fine. We could use a PR then.

@xm1234567
Copy link
Author

I just copy the lines from compose.yml into compose.folder.yml , is it worth a PR? or you can just add in future release :)

@mdellweg
Copy link
Member

mdellweg commented Jan 11, 2024

It's absolutely worth a PR.
Also we don't release the compose files from this repository.

@mikedep333 mikedep333 self-assigned this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: In Progress
Development

No branches or pull requests

3 participants