-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nginxplus: only the configs in our config directory should exist on the server #2750
Comments
The current role has a tasks file with a single task that "cleans up" the config. It removes the entire config directory. The role includes that file only when the variable Do we want that task to run every time we upload new configs? So that each time the playbook runs (unless it runs with If we only want that task to run occasionally, we can update the README and playbooks to document the existing behavior: "To remove all existing config files before uploading, pass |
Per @tpendragon we can use the synchronize module with |
Add a test for this new behavior. Probably needs a pre-task in molecule/default/converge.yml that adds an extraneous file, then a test in molecule/default/verify.yml that checks to be sure the file disappears when the playbook runs. |
Test for this as part of #3439 |
Related to #4654 - I think that PR should fix/close this ticket, except we are not testing for this behavior yet. |
e.g. if an old config is removed from ansible it should also be removed from the remote server.
Current behavior is that the old config is still there after the playbook has been run.
The text was updated successfully, but these errors were encountered: