Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade blacklight_range_limit to v9.0.0 #4705

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Upgrade blacklight_range_limit to v9.0.0 #4705

wants to merge 6 commits into from

Conversation

christinach
Copy link
Member

closes #4692

Supports Bootstrap 5

@christinach christinach force-pushed the 4692-bl-range-limit branch 4 times, most recently from 6884c18 to 0903ea5 Compare January 16, 2025 16:21
@pulbot pulbot requested a deployment to staging January 16, 2025 16:25 Abandoned
@christinach christinach force-pushed the 4692-bl-range-limit branch 4 times, most recently from 5222b70 to aa0d356 Compare January 17, 2025 15:36
@pulbot pulbot requested a deployment to staging January 17, 2025 15:37 Abandoned
@christinach christinach marked this pull request as ready for review January 17, 2025 16:01
@christinach christinach marked this pull request as draft January 17, 2025 16:02
@christinach
Copy link
Member Author

christinach commented Jan 18, 2025 •
edited
Loading

The blacklight range limit displays as expected in the home page.

The advanced search form fails with the following error

ActionView::Template::Error (undefined local variable or method 'response' for an instance of Hash):

This is triggered in:

/Users/cc62/.asdf/installs/ruby/3.4.1/lib/ruby/gems/3.4.0/gems/blacklight_range_limit-9.0.0/app/presenters/blacklight_range_limit/facet_field_presenter.rb

67   def stats_for_field
68      response.dig('stats', 'stats_fields', facet_field.field) || {}
69  end

I've also updated the catalog_controller to use the range_config and turned off the missing link.

@christinach christinach force-pushed the 4692-bl-range-limit branch 2 times, most recently from 6b22f10 to 4adcdf4 Compare January 22, 2025 20:52
christinach
christinach commented Jan 23, 2025
View reviewed changes
app/components/orangelight/advanced_search_form_component.html.erb Outdated
<label for="range_pub_date_start_sort_end" class="visually-hidden">Publication date range (ending year)</label>
<%= BlacklightRangeLimit::RangeFormComponent.new(facet_field: pub_date_presenter).render_range_input(:end) %>
<div class="col-sm-8">
<%= render BlacklightRangeLimit::RangeFormComponent.new(facet_field: pub_date_presenter) %>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the range limit is rendering the search submit button does not work.
I removed the Apply submit button of the range limit from the DOM but the Search submit still doesn't work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will override the range limit component in OL to see if it will resolve the issue

@christinach christinach force-pushed the 4692-bl-range-limit branch 3 times, most recently from 38c3fa9 to 3dd9f7c Compare January 23, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publication Year Range Facet Plugin "Run" button isn't labeled.
2 participants
@christinach @pulbot