Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publication Year Range Facet Plugin "Run" button isn't labeled. #4692

Open
3 tasks
kevinreiss opened this issue Jan 10, 2025 · 1 comment · May be fixed by #4705
Open
3 tasks

Publication Year Range Facet Plugin "Run" button isn't labeled. #4692

kevinreiss opened this issue Jan 10, 2025 · 1 comment · May be fixed by #4705

Comments

@kevinreiss
Copy link
Member

Expected behavior

When I use the Publication Range Year Facet date slider I can see a labeled "Run" or "Submit" button that will apply the date range I've selected to the results I am reviewing.

Actual behavior

The button to apply the range isn't labeled and is barely visible. See this screenshot.
Screenshot 2025-01-10 at 12 07 30 PM

Steps to replicate

  1. Got to catalog.princeton.edu
  2. Open the Publication Year Facet
  3. Try to find the "Run" option to the right of the date range slider.

Impact of this bug

Confusing using experiences. If you select the little bit of the run button the facet works.

Acceptance criteria

  • The "Run" button on the Publication Year Facet is visible.
  • I can successfully use this feature with Voice Over in Safari.
  • I have checked this feature using one of the following browser extensions and confirmed that it does not add any level A or level AA issues:
    • axe dev tools
    • Lighthouse
    • Wave
@rladdusaw
Copy link
Contributor

Could try upgrading to the new major version of the range-limit gem and see if it fixes the issue.

@christinach christinach self-assigned this Jan 15, 2025
@christinach christinach linked a pull request Jan 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants