Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eastasian$ql Holding Location should allow request to either the Firestone or East Asian Library Delivery Locations #4410

Open
1 task
kevinreiss opened this issue Oct 2, 2024 · 8 comments
Labels
maintenance Ticket related to maintenance that needs to be done

Comments

@kevinreiss
Copy link
Member

kevinreiss commented Oct 2, 2024

Expected behavior

All active public delivery locations for a holding location should display on the request form. The pickup locations are configured in bibdata. Eastasian$ql current has two public pickup locations configured that fit this description.

Actual behavior

See this example record from the location.

Screenshot 2024-10-02 at 5 10 03 PM

Steps to replicate

  1. Pull up any eastasian$ql item available for loan.
  2. Open the request form. Only East Asian Library is available as a choice.

Impact of this bug

Users cannot send items in this location to the Firsetone Library when they want to.

Acceptance Criteria

  • Items in eastasian$ql have both Firestone Library and East Asian Library as pick-up choices.

Notes

See: _requestable_delivery_option_in_library_use.html.erb
requestable_decorator.rb.

@kevinreiss kevinreiss added the bug 🐛 The application does not work as expected because of a defect label Oct 2, 2024
@christinach christinach self-assigned this Oct 10, 2024
@christinach
Copy link
Member

christinach commented Oct 11, 2024

@kevinreiss Eastasian$ql has pickup locations: true the following:
Technical Services 693
East Asian Library GFA Pickup: PL
Firestone Library GFA Pickup PF
Firestone Library, Resource Sharing
Technical Services HMT

which attribute defines that it's a public pickup location?Is it GFA Pickup PL and PF or is it the staff_only that we are looking to say that a location is a public pickup?

@kevinreiss
Copy link
Member Author

staff_only indicates a non-public pick-up location

@kevinreiss
Copy link
Member Author

If that isn't set it is for the public

@christinach
Copy link
Member

Ok I found another reference. I should be looking staff_only false

@kevinreiss
Copy link
Member Author

This issue needs further review with the circulation/holdings managers. This location presents a number of edge cases. Will put it on the agenda for the next upcoming meeting for review.

  1. It's a remote location part of a specific library.
  2. It's comprised on items marked noCirc
  3. It's wants non-circ items to be delivered to multiple campus libraries.

@mzelesky
Copy link
Member

@maxkadel
Copy link
Contributor

maxkadel commented Oct 24, 2024

@kevinreiss will rewrite this ticket and put back in backlog

@kevinreiss kevinreiss added maintenance Ticket related to maintenance that needs to be done and removed bug 🐛 The application does not work as expected because of a defect labels Oct 24, 2024
@kevinreiss kevinreiss changed the title eastasian$ql items should show all public delivery locations. eastasian$ql Holding Location should allow request to either the Firestone or East Asian Library Delivery Locations Oct 24, 2024
@kevinreiss
Copy link
Member Author

We can move forward with this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Ticket related to maintenance that needs to be done
Projects
None yet
Development

No branches or pull requests

4 participants