-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.1.5 (or higher) #9
Comments
Kinetic requires some minor adjustments due to the switch to Qt5. That's
not a problem and has already been done on the kinetic branch, but do you
know any best practices regarding the versioning? Should I release it under
the same number if it only includes the compatibility changes and then keep
merging changes like I did it now for your PR? Or is there another way?
|
There's a discussion right in time for your concern. In a nutshell, I recommend to increment the minor version (in this case to make 0.2.x for Kinetic). |
Incrementing the minor version seems a bit odd to me, it is meant to be
used for feature changes in the first place. Indigo/jade and kinetic
versions have the same features, they just need to be realized slightly
differently because of dependencies. This should be transparent. Also, if I
release a new feature for indigo/jade, I would either need to increment the
number twice or end up with the same as used for kinetic.
The reference posted by Tully in the discussion you suggested mentions
another option. It should be possible to use versions like "1.4.0" and
"1.4.0+kinetic". By definition, these two are incomparable and none has
precedence. If I add a new feature, I can increment both to 1.5.0. Not sure
if this is accepted in practice and works with bloom, but looks reasonable
to me.
|
I guess that's also a valid concern.
I'm personally not sure if |
While I'm curious to resolve #10 (or confirm that #10 isn't actually an issue), I'm personally craving for #5 to be available via DEB. For the version number, I think you can try making a release with Only thing I should highlight is that you never want to use the same version for different package content (regardless the difference is feature/config/bugfix/whitespace/etc.) Using the same version number for different code, there won't be any way to tell from each other, which could make debugging unnecessarily harder. |
Trying to release 0.1.5 right now (indigo, jade) and will continue with attempting to release 0.1.5+kinetic afterwards. Internet is really slow, but I hope it will be sufficient. Otherwise I will try to finish it by tomorrow. |
Unfortunately, no luck with the I will release it as |
|
Thanks!
Also please consider making it into ROS Kinetic.
The text was updated successfully, but these errors were encountered: