Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1.5 (or higher) #9

Closed
130s opened this issue Nov 6, 2016 · 8 comments
Closed

Release 0.1.5 (or higher) #9

130s opened this issue Nov 6, 2016 · 8 comments

Comments

@130s
Copy link
Contributor

130s commented Nov 6, 2016

Thanks!

Also please consider making it into ROS Kinetic.

@pschillinger
Copy link
Owner

pschillinger commented Nov 6, 2016 via email

@130s
Copy link
Contributor Author

130s commented Nov 6, 2016

There's a discussion right in time for your concern. In a nutshell, I recommend to increment the minor version (in this case to make 0.2.x for Kinetic).

@pschillinger
Copy link
Owner

pschillinger commented Nov 6, 2016 via email

@130s
Copy link
Contributor Author

130s commented Nov 7, 2016

I guess that's also a valid concern.

"1.4.0" and "1.4.0+kinetic"

I'm personally not sure if bloom supports it but I think it's worthwhile giving a shot.

@130s
Copy link
Contributor Author

130s commented Dec 10, 2016

While I'm curious to resolve #10 (or confirm that #10 isn't actually an issue), I'm personally craving for #5 to be available via DEB.

For the version number, I think you can try making a release with 1.4.0+kinetic. bloom is rigorous enough to be bug-free so it'll tell if your format is not allowed so that you wouldn't mess up rosdistro. It's also possible, however, that bloom would pass but you would still mess, but then you just open a fix PR (ROS buildfarm maintainers are very forgiving :) ).

Only thing I should highlight is that you never want to use the same version for different package content (regardless the difference is feature/config/bugfix/whitespace/etc.) Using the same version number for different code, there won't be any way to tell from each other, which could make debugging unnecessarily harder.

@pschillinger
Copy link
Owner

Trying to release 0.1.5 right now (indigo, jade) and will continue with attempting to release 0.1.5+kinetic afterwards. Internet is really slow, but I hope it will be sufficient. Otherwise I will try to finish it by tomorrow.

@pschillinger
Copy link
Owner

Unfortunately, no luck with the +kinetic option:
catkin_pkg.package.InvalidPackage: Invalid package manifest "././package.xml": Package version "0.1.4+kinetic" does not follow version conventions

I will release it as 0.2.0 for kinetic then (same features/fixes as 0.1.5 for indigo/jade).

@pschillinger
Copy link
Owner

rqt_launchtree 0.2.0 will be in the next update of kinetic as soon as the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants