Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL Reachability guard returns incorrect urls #189

Open
sosafe-jose-gonzalez opened this issue Sep 20, 2024 · 1 comment
Open

URL Reachability guard returns incorrect urls #189

sosafe-jose-gonzalez opened this issue Sep 20, 2024 · 1 comment

Comments

@sosafe-jose-gonzalez
Copy link

Describe the bug
When running the URL Reachability guard the extract_urls function doesn't return correctly the urls in the text.

I've tested this with the text

3. **Login:** Go to the Salesforce login page at [login.salesforce.com](https://login.salesforce.com) and enter your credentials.

To Reproduce
Steps to reproduce the behavior:

  1. Run the function extract_urls
  2. Get a list of urls
  3. It returns https://login.salesforce.com)

Expected behavior
It should return https://login.salesforce.com without bracket.
@sosafe-jose-gonzalez sosafe-jose-gonzalez changed the title URL Reachability guard returns incorrect urls. URL Reachability guard returns incorrect urls Sep 20, 2024
@sosafe-jose-gonzalez
Copy link
Author

Maybe it could use remove_markdown before extracting the URLs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sosafe-jose-gonzalez