Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error feedback for adapters, in the frontend. #292

Open
jonasfroeller opened this issue Nov 22, 2024 · 0 comments
Open

Improve error feedback for adapters, in the frontend. #292

jonasfroeller opened this issue Nov 22, 2024 · 0 comments
Assignees
Labels
task Work, to do.
Milestone

Comments

@jonasfroeller
Copy link
Member

jonasfroeller commented Nov 22, 2024

  • If REST-API errors,
    • use cached data for projects that already exist and
    • display info message in dashboard.
  • Display: "Provider is currently under maintainance",
    • if user wants to use an adapter, that is currently unavailable and
    • disable it from the selection.

The problem: Github Graphql sometimes returns weird html.

<!DOCTYPE html>\n<html>\n<head>\n  <title>The change you wanted was rejected (422)</title>\n  <meta name=\"viewport\" content=\"width=device-width,initial-scale=1\">\n  <style>\n  body {\n    background-color: #EFEFEF;\n    color: #2E2F30;\n    text-align: center;\n    font-family: arial, sans-serif;\n    margin: 0;\n  }\n\n  div.dialog {\n    width: 95%;\n    max-width: 33em;\n    margin: 4em auto 0;\n  }\n\n  div.dialog > div {\n    border: 1px solid #CCC;\n    border-right-color: #999;\n    border-left-color: #999;\n    border-bottom-color: #BBB;\n    border-top: #B00100 solid 4px;\n    border-top-left-radius: 9px;\n    border-top-right-radius: 9px;\n    background-color: white;\n    padding: 7px 12% 0;\n    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);\n  }\n\n  h1 {\n    font-size: 100%;\n    color: #730E15;\n    line-height: 1.5em;\n  }\n\n  div.dialog > p {\n    margin: 0 0 1em;\n    padding: 1em;\n    background-color: #F7F7F7;\n    border: 1px solid #CCC;\n    border-right-color: #999;\n    border-left-color: #999;\n    border-bottom-color: #999;\n    border-bottom-left-radius: 4px;\n    border-bottom-right-radius: 4px;\n    border-top-color: #DADADA;\n    color: #666;\n    box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);\n  }\n  </style>\n</head>\n\n<body>\n  <!-- This file lives in public/422.html -->\n  <div class=\"dialog\">\n    <div>\n      <h1>The change you wanted was rejected.</h1>\n      <p>Maybe you tried to change something you didn't have access to.</p>\n    </div>\n    <p>If you are the application owner check the logs for more information.</p>\n  </div>\n</body>\n</html>\n

Image
Image

@jonasfroeller jonasfroeller converted this from a draft issue Nov 22, 2024
@jonasfroeller jonasfroeller self-assigned this Nov 22, 2024
@jonasfroeller jonasfroeller added task Work, to do. sprint-11 sprint info labels Nov 22, 2024
@jonasfroeller jonasfroeller added this to the Stable milestone Nov 22, 2024
@jonasfroeller jonasfroeller added sprint-12 sprint info and removed sprint-11 sprint info labels Nov 30, 2024
@propromo-software propromo-software bot removed the sprint-12 sprint info label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work, to do.
Projects
Status: Todo
Development

No branches or pull requests

2 participants