From c733db831245b4d1913326182341510d664cfdf8 Mon Sep 17 00:00:00 2001 From: beforetech Date: Wed, 31 Jul 2024 22:03:50 +0800 Subject: [PATCH 1/2] chore: fix some comments Signed-off-by: beforetech --- CONTRIBUTING.md | 4 ++-- docs/content/guides/rancher-projects/capsule-rancher.md | 2 +- e2e/ingress_class_networking_test.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c6040fa2..210418f6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -70,7 +70,7 @@ git clone https://hostname/YOUR-USERNAME/YOUR-REPOSITORY 2. **Create a branch:** -Create a new brach and navigate to the branch using this command. +Create a new breach and navigate to the branch using this command. ```sh git checkout -b @@ -180,7 +180,7 @@ The semantics should indicate the change and it's impact. The general format for The following types are allowed for commits and pull requests: * `chore`: housekeeping changes, no production code change - * `ci`: changes to buillding process/workflows + * `ci`: changes to building process/workflows * `docs`: changes to documentation * `feat`: new features * `fix`: bug fixes diff --git a/docs/content/guides/rancher-projects/capsule-rancher.md b/docs/content/guides/rancher-projects/capsule-rancher.md index 36930aa5..5fd34d37 100644 --- a/docs/content/guides/rancher-projects/capsule-rancher.md +++ b/docs/content/guides/rancher-projects/capsule-rancher.md @@ -70,7 +70,7 @@ When onboarding tenants, the administrator needs to create the following, in ord #### Create the Tenant Member Project Role -A custom `Project Role` is needed to allow Tenant users, with minimun set of privileges and create and delete `Namespace`s. +A custom `Project Role` is needed to allow Tenant users, with minimum set of privileges and create and delete `Namespace`s. Create a Project Role named *Tenant Member* that inherits the privileges from the following Roles: - *read-only* diff --git a/e2e/ingress_class_networking_test.go b/e2e/ingress_class_networking_test.go index 0dfe358d..60caa004 100644 --- a/e2e/ingress_class_networking_test.go +++ b/e2e/ingress_class_networking_test.go @@ -564,7 +564,7 @@ var _ = Describe("when Tenant handles Ingress classes with networking.k8s.io/v1" Expect(*i.Spec.IngressClassName).To(Equal(class.GetName())) }) - It("shoult mutate to default tenant IngressClass although the cluster global one is not allowed", func() { + It("should mutate to default tenant IngressClass although the cluster global one is not allowed", func() { if err := k8sClient.List(context.Background(), &networkingv1.IngressList{}); err != nil { if utils.IsUnsupportedAPI(err) { Skip(fmt.Sprintf("Running test due to unsupported API kind: %s", err.Error())) From c1796d1b26d65d4bd12ba1426ce063fca8b7b96b Mon Sep 17 00:00:00 2001 From: Dario Tranchitella Date: Thu, 1 Aug 2024 17:45:47 +0200 Subject: [PATCH 2/2] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 210418f6..f90ad2f9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -70,7 +70,7 @@ git clone https://hostname/YOUR-USERNAME/YOUR-REPOSITORY 2. **Create a branch:** -Create a new breach and navigate to the branch using this command. +Create a new branch and navigate to it using this command. ```sh git checkout -b