Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sender_info needs valid values #1

Open
laroque opened this issue Mar 1, 2017 · 2 comments
Open

sender_info needs valid values #1

laroque opened this issue Mar 1, 2017 · 2 comments
Assignees
Labels

Comments

@laroque
Copy link
Member

laroque commented Mar 1, 2017

Ideally these can be generated dynamically, if that's not easy/possible, there need to be valid values stored somewhere and used throughout.

@laroque laroque added the bug label Mar 1, 2017
@laroque laroque self-assigned this Mar 1, 2017
@nsoblath
Copy link
Member

nsoblath commented Mar 2, 2017

In the h2d version of firefly I had taken care of a few of the fields. Perhaps that's useful here.

  • hostname: dynamicall filled in with the built-in php function gethostname()
  • package: hardcoded as firefly
  • exe: hardcoded as none. Perhaps instead you could use the page name that generated the request.

@laroque
Copy link
Member Author

laroque commented Mar 2, 2017

done thus far:

  • username: from the session cookie if present, otherwise <unknown> (firefly should not allow access to pages if you aren't logged in, demo page from dripline-web still behaves reasonably)
  • exe: will be the webpage used to send the request
  • package: always dripline-web
  • hostname: from gethostname()

I don't have a good solution for commit and version other than manually storing/updating them from a file (which is gross and error prone). The container doesn't have git installed so git describe isn't an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants