Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCA buildCovariance and app do not superpose well for projections #2024

Open
yasirkhanqu opened this issue Jan 15, 2025 · 1 comment
Open

Comments

@yasirkhanqu
Copy link

The prody pca app uses DCDFile when the number of frames > 1000 (

if len(dcd) > 1000:
) and uses the aligned kwarg of buildCovariance to control whether the trajectory frames should be superposed (
frame.superpose()
).

This works for updating the frames themselves outside the DCDFile trajectory object, giving the right PCA, but does not update the DCDFile coordinates, so the projections are wrong from this DCDFile.

One should find a way to update the DCDFile or extract the frame coordinates into a new array, perhaps as an attribute of the PCA object, which can be used for the projections.

@yasirkhanqu
Copy link
Author

It would also be good to write a new aligned trajectory file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant