Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Type Definitions #448

Open
3 tasks
JonathanWenger opened this issue Jun 30, 2021 · 0 comments
Open
3 tasks

Duplicate Type Definitions #448

JonathanWenger opened this issue Jun 30, 2021 · 0 comments
Labels
diffeq Issues related to differential equations randprocs Issues related to random processes refactoring Refactoring of existing functionality

Comments

@JonathanWenger
Copy link
Contributor

In a Nutshell

Duplicate types ToleranceDiffusionType and DenseOutputLocationArgType, which are just aliases for the same expression Union[FloatArgType, np.ndarray]

In Detail

There are type definitions in probnum.type, which define the same general concept, namely a variable which is either a scalar or an array. Currently there are two overly specific names for this type, once given as an arg type, suggesting there is some type normalization coming after and once not.

TODO

  • Investigate usages of ToleranceDiffusionType and DenseOutputLocationArgType to determine whether there is type normalization (meaning functionality which converts the input to a common type, e.g. a np.array) going on
  • Define a single (argument) type ScalarOrArrayArgType superseding the overly specific types above or simply replace with Union[FloatArgType, np.ndarray]
  • Move new arg type under Argument types in probnum.type
@JonathanWenger JonathanWenger added refactoring Refactoring of existing functionality diffeq Issues related to differential equations statespace labels Jun 30, 2021
@JonathanWenger JonathanWenger added this to the Dagstuhl Workshop milestone Jul 8, 2021
@pnkraemer pnkraemer added randprocs Issues related to random processes and removed statespace labels Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diffeq Issues related to differential equations randprocs Issues related to random processes refactoring Refactoring of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants