Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrapping UnionAll in split_method #35

Open
JanJecmen opened this issue Aug 21, 2023 · 1 comment
Open

Unwrapping UnionAll in split_method #35

JanJecmen opened this issue Aug 21, 2023 · 1 comment
Labels
bug Something isn't working p:low question Further information is requested

Comments

@JanJecmen
Copy link
Collaborator

@ulysses4ever This seems like a typo:

https://github.com/ulysses4ever/julia-sts/blob/cecb805d069b8ad41220e46f182fc74f98f5afcb/src/utils.jl#L92-L93

If m.sig is a UnionAll, the function immediately returns. So then calling Base.unwrap_unionall(m.sig) is a noop.
Right?

@JanJecmen JanJecmen added bug Something isn't working question Further information is requested labels Aug 21, 2023
@ulysses4ever
Copy link
Collaborator

Yep, seems so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p:low question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants