fix: get around port collisions with a random port #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updating test folder to match setup of internal ‘plugin’ library
|
Deploy request for graphql-nexus pending review. Review with commit fac447d |
|
I opted to do a little code structuring in the 'testing' folder so that it matches the structure of the 'plugin' folder. If that isn't wanted, I can close this PR and make a new one with this simpler branch. |
|
Windows tests are flaky, re-running via force-push. :( |
haysclark
force-pushed
the
parrallel-testing
branch
2 times, most recently
from
f059254
to
98b29cb
Compare
- during testing, get-port often re-uses the same port, due to the delay between when a free-port is assigned to a test, and when the port is actually used. Simply supplying an initial random port value to get-port dramatically reduces the chance of a port being used multiple times in a test run. - testing on CI environments should still utilize Jest’s `—runInBand` flag
haysclark
force-pushed
the
parrallel-testing
branch
from
98b29cb
to
fac447d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1326
—runInBandflag