Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More room with objects #326

Closed
hpc100 opened this issue Sep 18, 2024 · 9 comments
Closed

More room with objects #326

hpc100 opened this issue Sep 18, 2024 · 9 comments
Labels
question Further information is requested

Comments

@hpc100
Copy link

hpc100 commented Sep 18, 2024

Hello,
Thank's for your work.

Problems

I ran your command to generate indoor whole appartement, however I noticed that only one room contains objects (like you say in md file) (see illustration)

Steps to Reproduce

python -m infinigen.datagen.manage_jobs --output_folder outputs/my_dataset --num_scenes 1 --pipeline_configs local_256GB.gin monocular.gin blender_gt.gin indoor_background_configs.gin --configs singleroom.gin --pipeline_overrides get_cmd.driver_script='infinigen_examples.generate_indoors' LocalScheduleHandler.use_gpu=False manage_datagen_jobs.num_concurrent=16 --overrides compose_indoors.restrict_single_supported_roomtype=True compose_indoors.terrain_enabled=False --overwrite

Figure

Multiple_room_but_one_with_object

Question

I would like to know which parameter I need to modify, if i want to place object in all rooms ? (compose_indoors ? or another parameter ?)

Thank's in advance.

@hpc100 hpc100 added the question Further information is requested label Sep 18, 2024
@araistrick
Copy link
Contributor

araistrick commented Sep 21, 2024

If you want multiple rooms to be solved with objects, you should remove --configs singleroom.gin from your command, as this causes us to only generate a layout for a single room.

Please reopen if this does not resolve the issue

@GavinZhengOI
Copy link

Hi Araistrick @araistrick, I'm using the exact same config with --configs singleroom.gin and --overrides compose_indoors.restrict_single_supported_roomtype=True deleted. It runs for tens of hours and ultimately result in a crash.

Here are some info provided by crash_summary:

09/21 12:07AM outputs/video_multiroom_dataset/5db391c0/logs/coarse.err reason='AssertionError:  ' node=None fatal=True
09/21 04:21PM outputs/huge_dataset_nooverride/b69f95a/logs/coarse.err reason='ValueError:  Could not find 1 camera views' node=None fatal=True
09/22 08:33AM outputs/huge_dataset_nooverride/69c2b33d/logs/coarse.err reason='AssertionError:  ' node=None fatal=True

One of the example of coarse.err:

raise proxy.with_traceback(exception.__traceback__) from None  File "/home/gavinzheng/miniconda3/envs/infinigen/lib/python3.10/site-packages/gin/config.py", line 1582, in gin_wrapper
    return fn(*new_args, **new_kwargs)  File "/home/gavinzheng/Documents/infinigen/infinigen/core/constraints/example_solver/annealing.py", line 207, in retry_attempt_proposals
    succeeded = move.apply(state)  File "/home/gavinzheng/Documents/infinigen/infinigen/core/constraints/example_solver/moves/addition.py", line 90, in apply
    assert target_name not in state.objsAssertionError: 
  In call to configurable 'retry_attempt_proposals' (<function SimulatedAnnealingSolver.retry_attempt_proposals at 0x74c67e3d7400>)
  In call to configurable 'solve_objects' (<function Solver.solve_objects at 0x74c67e3f6200>)
  In call to configurable 'compose_indoors' (<function compose_indoors at 0x74c67d835750>)
  In call to configurable 'execute_tasks' (<function execute_tasks at 0x74c67dbe6a70>)

If I don't delete --configs singleroom.gin and --overrides compose_indoors.restrict_single_supported_roomtype=True, everything is working well. Could you provides some insight to this problem? Let me know if you need any other info. Thanks!

@hpc100
Copy link
Author

hpc100 commented Sep 25, 2024

@araistrick thank's for your answer. I run this command and it work well. However I noticed that for each scene, one room is alway empty. Do you have any idea ?
@GavinZhengOI do you noticed the same issue ?
Iamge2
Image1

Thank's.

@GavinZhengOI
Copy link

@hpc100 No I didn't notice this specific issue, my every attempt to generate a full room will result in a crash(#333 for more detail). Could you share what is the exact command you use? And how much RAM do you have? Thanks!

@hpc100
Copy link
Author

hpc100 commented Sep 26, 2024

I run this command
python -m infinigen.datagen.manage_jobs --output_folder outputs/my_dataset --num_scenes 1000 --pipeline_configs local_256GB.gin monocular.gin blender_gt.gin indoor_background_configs.gin --pipeline_overrides get_cmd.driver_script='infinigen_examples.generate_indoors' LocalScheduleHandler.use_gpu=False manage_datagen_jobs.num_concurrent=16 --overrides compose_indoors.terrain_enabled=False --overwrite
with 188G RAM

@GavinZhengOI
Copy link

GavinZhengOI commented Sep 27, 2024

I run this command python -m infinigen.datagen.manage_jobs --output_folder outputs/my_dataset --num_scenes 1000 --pipeline_configs local_256GB.gin monocular.gin blender_gt.gin indoor_background_configs.gin --pipeline_overrides get_cmd.driver_script='infinigen_examples.generate_indoors' LocalScheduleHandler.use_gpu=False manage_datagen_jobs.num_concurrent=16 --overrides compose_indoors.terrain_enabled=False --overwrite with 188G RAM

Got it. It seems like I didn't allocate enough memory. I'll switch to another server and have a try. Get back to you later. By the way how long does it take for you to generate a scene like this?

@hpc100
Copy link
Author

hpc100 commented Oct 4, 2024

approx one day

@GavinZhengOI
Copy link

@araistrick thank's for your answer. I run this command and it work well. However I noticed that for each scene, one room is alway empty. Do you have any idea ? @GavinZhengOI do you noticed the same issue ? Iamge2 Image1

Thank's.

Hi, I checked my result, and there is indeed an empty room, but it’s a very small one. I suspect it might be a storage space.
Screenshot from 2024-10-14 18-34-41

@hpc100
Copy link
Author

hpc100 commented Oct 15, 2024

Hi, thank's for your feedback. I also checked the empty room and noticed that it's often garage and hallway, it's might be normal.

@hpc100 hpc100 closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants