Fixed offset when dragging in scroll container #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md
…rag position in scrolled documents.
remove componentWillReceiveProps and swap with componentDidUpdate
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.10...4.17.15) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.1 to 1.4.7. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.4.1...1.4.7) Signed-off-by: dependabot[bot] <[email protected]>
…n/lodash-4.17.15 Bump lodash from 4.17.10 to 4.17.15
…n/url-parse-1.4.7 Bump url-parse from 1.4.1 to 1.4.7
…n/mixin-deep-1.3.2 Bump mixin-deep from 1.3.1 to 1.3.2
…ing; add classes: `--with-children`, `--children-open`, `--children-collapsed`.
|
@primetwig can this get pushed up the chain? I'm also having an issue within a scrollable container and would love a fix. |
|
Hi, is it possible to merge this PR, the fix works like a charm for me (installed it from the fork) 🙏 |
|
@primetwig hi, any update on merging this? Is there more work that needs to be done? I really like this library, but this is a serious bug for me. |
|
I updated this merge request to the latest code so there are no more merge conflicts. See this pull request. #88 |
Var-J
added a commit
to Eventur/react-nestable-old
that referenced
this pull request
May 23, 2023
Fixed offset when dragging in scroll container primetwig#56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #29