Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking deployment flow #18

Open
3 tasks
lewisjared opened this issue Oct 25, 2023 · 0 comments
Open
3 tasks

Reworking deployment flow #18

lewisjared opened this issue Oct 25, 2023 · 0 comments

Comments

@lewisjared
Copy link
Collaborator

We need to streamline the build and deploy process as the huge number of files makes it difficult to see what really changed.

I'm proposing that we move to using a GitHub action to build and deploy the required files and HTML (https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#publishing-with-a-custom-github-actions-workflow). This would involve no longer tracking the docs/primap-hist/data directory as that is populated during the build process.

We should also support pull request previews. These pull request previews build and deploys so that the updates can be checked as part of the PR. See https://github.com/marketplace/actions/deploy-pr-preview

Definition of done

  • Verify downloading and building can be performed on the CI
  • Add GH actions to build
  • Add GH action to generate deploy previews

Alternative Option

Use netlify like the other CR websites, but that maybe overkill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant