Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function collision with another plugin #20

Open
brimby opened this issue Apr 23, 2020 · 0 comments
Open

Function collision with another plugin #20

brimby opened this issue Apr 23, 2020 · 0 comments

Comments

@brimby
Copy link

brimby commented Apr 23, 2020

Both your plugin and craft-color-mixer by whoisjuan have a filter function called hexToRgb. In my installation your function gets priority when I use the filter. The problem is the two functions return different values, with yours printing "rgb(0,0,0)" and his printing just "0,0,0". So this created quite a bit of confusion and headaches when I was expecting to see the latter and didn't realize your plugin had its own set of filter functions. I submitted an issue with his plugin too, and I'm sure neither of you would want to change the name or return format for your functions, but something should be worked out in order to not confuse people who install both of your plugins like I did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant