fix: Make sure that environments are not completely overridden #2396
Conversation
hameerabbasi
changed the title
hameerabbasi
force-pushed
the
default-platform-mixed-env
branch
2 times, most recently
from
9639c5a
to
d8b53f0
Compare
hameerabbasi
force-pushed
the
default-platform-mixed-env
branch
from
d8b53f0
to
9ac30f9
Compare
There was a problem hiding this comment.
Thank you! The PR looks good from an implementation stand point!
However this will be a breaking change of the configuration.
Users would need to switch from:
[activation]
scripts = ["default.sh"]
[target.win-64.activation]
scripts = ["default.bat"]To:
[target.unix.activation]
scripts = ["default.sh"]
[target.win.activation]
scripts = ["default.bat"]To not have a broken experience.
I'll contact the team what we'll do with this.
|
I get the implementation from the perspective of environment variables. I would indeed want to use the environment variables from all the targets and have them override each other based on environment variable name. However, for activation scripts, I would not want to combine them. I think we should make this distinction is properly made. Alternatively we could also change the |
I do like the script map idea; it also occurred to me. However; my concern is that existing user configs would be broken by this. |
|
I've reverted the changes to activation scripts in 720db9e; but kept ones for envs to get this in faster. |
Fixes #2383