Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests and automated testing #1

Open
BenjaminRodenberg opened this issue Nov 28, 2019 · 3 comments
Open

Add unit tests and automated testing #1

BenjaminRodenberg opened this issue Nov 28, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@BenjaminRodenberg
Copy link
Member

We should add some easy-to-run unit tests. We will probably have to use some kind of mock testing (similar to https://github.com/precice/python-bindings), since we cannot simply run MATLAB via travis due to the license.

@BenjaminRodenberg BenjaminRodenberg added the enhancement New feature or request label Nov 28, 2019
@ghost ghost mentioned this issue Nov 28, 2019
2 tasks
@BenjaminRodenberg
Copy link
Member Author

See also precice/precice#409

@ghost
Copy link

ghost commented Feb 2, 2020

A testing procedure with docker was added in #16. Currently tests the bindings by running the solverdummy and both tutorials (explicit and implicit coupling).

The testing starts from a docker image with Ubuntu 18.04 and MATLAB. The procedure for generating such image can be found in the test/0-matlab directory of the PR.

@ghost ghost mentioned this issue Feb 4, 2020
@BenjaminRodenberg
Copy link
Member Author

#16 implements what we are referring to as a systemtest (see https://github.com/precice/systemtests). However, what we also need (since the systemtest only covers a few of the API functions) are comprehensive unit tests for the API. One possible implementation of this is using a mocked up preCICE SolverInterface.cpp like in the python-bindings (see https://github.com/precice/python-bindings/tree/develop/test).

@BenjaminRodenberg BenjaminRodenberg unassigned ghost Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant