From 79669e6470715b7ef987ee28ab539c9bd94a6dbc Mon Sep 17 00:00:00 2001 From: Anton Babak <76536883+AntoxaAntoxic@users.noreply.github.com> Date: Mon, 28 Oct 2024 10:08:25 +0100 Subject: [PATCH] Github: Add Reviewer Checklist (#3520) --- .github/pull_request_template.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f15985dc6a4..28ce307df13 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -19,6 +19,15 @@ What's the context for the changes? Are there any Why did you choose to make these changes? Were there any trade-offs you had to consider? +### ๐Ÿ”Ž New Bid Adapter Checklist +- [ ] verify email contact works +- [ ] NO fully dynamic hosts +- [ ] geographic host parameters are NOT required +- [ ] NO direct use of HTTP is prohibited - *implement an existing Bidder interface that will do all the job* +- [ ] if the ORTB is just forwarded to the endpoint, use the generic adapter - *define the new adapter as the alias of the generic adapter* +- [ ] cover an adapter configuration with an integration test + + ### ๐Ÿงช Test plan How do you know the changes are safe to ship to production?