Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider shape is different on stable vs lazer #24841

Closed
peppy opened this issue Sep 18, 2023 · 6 comments
Closed

Slider shape is different on stable vs lazer #24841

peppy opened this issue Sep 18, 2023 · 6 comments
Labels
area:beatmap-parsing .osu file format parsing priority:1 Very important. Feels bad without fix. Affects the majority of users.

Comments

@peppy
Copy link
Member

peppy commented Sep 18, 2023

Notice the slider path extends slightly about the head circle.

lazer stable
image image

https://osu.ppy.sh/beatmapsets/714359#osu/1509693
01:09:439 (1)

Transferred from report on twitter: https://twitter.com/windr727/status/1703205933688533359

@peppy peppy added area:beatmap-parsing .osu file format parsing priority:1 Very important. Feels bad without fix. Affects the majority of users. labels Sep 18, 2023
@windrosu
Copy link

If it helps, I made a recording of me moving this anchor to show the difference in behavior

2023-09-18.13-04-46.mp4

It seems like the curve change in Lazer is more smooth than it is in Stable

@Magnus-Cosmos
Copy link
Contributor

Magnus-Cosmos commented Sep 18, 2023

The slider paths are the same (if you watch Auto on Stable slowed down, the slider ball goes upwards for a split second):
osu-stable_slider
The difference is that Stable renders the slider body differently, it "merges" the paths when the distance between them is 6px or less. In this case, the "backwards" paths are completely gone since their max distance from the starting position is less than 3px.

@bdach
Copy link
Collaborator

bdach commented Sep 20, 2023

If that's the case I'd argue that we probably could leave this be since lazer is arguably more correct?

@Magnus-Cosmos
Copy link
Contributor

I'd say so too, majority of maps aren't affected by this and gameplay wise there shouldn't be any difference.

@peppy
Copy link
Member Author

peppy commented Sep 25, 2023

Going to close this one as "working as intended" based on the above conversation.

@peppy peppy closed this as completed Sep 25, 2023
@bdach bdach marked this as a duplicate of #31688 Jan 27, 2025
@smoogipoo
Copy link
Contributor

This was fixed for Catmull sliders here: #27734, and I believe there was a reason I didn't apply the fix universally. We may want to revisit this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:beatmap-parsing .osu file format parsing priority:1 Very important. Feels bad without fix. Affects the majority of users.
Projects
None yet
Development

No branches or pull requests

5 participants