Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osu api always show "F" rank from get_match #11591

Closed
hayasakachan opened this issue Oct 26, 2024 · 3 comments · Fixed by #11644
Closed

osu api always show "F" rank from get_match #11591

hayasakachan opened this issue Oct 26, 2024 · 3 comments · Fixed by #11644
Labels
type:api

Comments

@hayasakachan
Copy link

hayasakachan commented Oct 26, 2024 •
edited
Loading

Code
Code_mo1cjrEchp
Result
WindowsTerminal_x77y3RhNZK
Match link: https://osu.ppy.sh/community/matches/115977090
Score: https://osu.ppy.sh/scores/3744935251
@peppy
Copy link
Member

peppy commented Nov 13, 2024

Is this API v2 or v1?

@peppy peppy added the type:api label Nov 13, 2024
@hayasakachan
Copy link
Author

It is API v2

@nanaya
Copy link
Collaborator

nanaya commented Nov 13, 2024

the rank column in game_scores doesn't seem to contain any values other than 0 (which then gets converted to F)

@nanaya nanaya mentioned this issue Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:api
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix legacy match score rank value nanaya/osu-web
3 participants
@peppy @nanaya @hayasakachan