Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for client reconnection #193

Open
Tracked by #24609
bdach opened this issue Oct 26, 2023 · 1 comment
Open
Tracked by #24609

Add support for client reconnection #193

bdach opened this issue Oct 26, 2023 · 1 comment

Comments

@bdach
Copy link
Collaborator

bdach commented Oct 26, 2023

Disregarding all discussion above, a first point to address is the ability for a user to reconnect to osu-server-spectator. Regardless of whether we move responsibilities around, we need to ensure that a dropped websocket connection is not the end of the world for multiplayer, spectator, and (currently) replay storage.

Once we have this in place, we can decide whether responsibilities need to be shuffled.

Originally posted by @peppy in ppy/osu#24609 (comment)


The key part for the issue above is spectating flows, as they are the ones that implicitly participate in submission to upload replays. This will likely require a reconciliation flow which ensures that the client resends any frames the server might not have received.

The rest is also important for other reasons, but strictly speaking not for the aforementioned issue.

@peppy
Copy link
Member

peppy commented Dec 20, 2023

Moving out of project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants