Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] the backbuffer format is always SRGB #42

Open
zhaijialong opened this issue Jun 5, 2019 · 2 comments
Open

[BUG] the backbuffer format is always SRGB #42

zhaijialong opened this issue Jun 5, 2019 · 2 comments
Labels

Comments

@zhaijialong
Copy link

zhaijialong commented Jun 5, 2019

Description

The emulator doesn't say it support EGL_KHR_gl_colorspace, but always create a r8g8b8a8_unorm_srgb format backbuffer in the underlying implementation.

It should use a linear format backbuffer as default if doesn't support EGL_KHR_gl_colorspace.

The better way is to expose the EGL_KHR_gl_colorspace egl extension, and let user to config it to determine whether to use a srgb backbuffer

EGLint eglSurfaceAttributes[3]
eglSurfaceAttributes[0] = EGL_GL_COLORSPACE_KHR;
eglSurfaceAttributes[1] = EGL_GL_COLORSPACE_SRGB_KHR;
eglSurfaceAttributes[2] = EGL_NONE;
egl::CreateWindowSurface(..., eglSurfaceAttributes)

Repro steps

Environment

  • SDK version: 18.2@5236813
  • Operating System/Device: Windows 10/GTX 1060

Additional Info

And the emulator says it support EGL 1.5, EGL_KHR_gl_colorspace should be in EGL 1.5. But if I try

EGLint eglSurfaceAttributes[3]
eglSurfaceAttributes[0] = EGL_GL_COLORSPACE;
eglSurfaceAttributes[1] = EGL_GL_COLORSPACE_SRGB;
eglSurfaceAttributes[2] = EGL_NONE;
egl::CreateWindowSurface(..., eglSurfaceAttributes)

the egl::CreateWindowSurface will hang my process.

@zhaijialong zhaijialong added the bug label Jun 5, 2019
@graptis
Copy link
Contributor

graptis commented Jun 5, 2019

Hi @zhaijialong,
Thanks for the report.
I have forwarded this to the engineers responsible for PVRVFrame, but since this is a matter of Tools and not the actual codebase of the SDK, support will arguably be better in https://forums.imgtec.com/ which are for this purpose only. I would suggest opening an issue there (as well?).
(We can still keep this issue open, but probably feedback will be sparse).

@zhaijialong
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants