Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart encapsulation #27

Closed
maltsev opened this issue Mar 3, 2016 · 4 comments
Closed

Smart encapsulation #27

maltsev opened this issue Mar 3, 2016 · 4 comments

Comments

@maltsev
Copy link
Member

maltsev commented Mar 3, 2016

@stevenvachon:

switch between ' and " (per attribute) as attribute value encapsulators to find which produces the smallest output (due to any necessary commenting: attr='blah 'blah'' vs attr="blah 'blah'")

@wooorm
Copy link

wooorm commented Jan 4, 2019

Here’s what I settled for.

@kevincox
Copy link

kevincox commented Feb 21, 2020

I wouldn't be surprised if this actually raised the gzip size on average. Unless you have a large number of strings with only one type of quote consistency probably gives you the smallest result after compression.

@maltsev
Copy link
Member Author

maltsev commented Feb 24, 2020

@kevincox very good point! We should test that before starting to implement that minification.

@SukkaW
Copy link
Contributor

SukkaW commented Nov 25, 2020

The feature has been implemented in posthtml/posthtml-render#47 so the issue could be closed now.

@maltsev maltsev closed this as completed Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants