Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions workflows use deprecated/outdated actions #132

Open
esabol opened this issue Oct 15, 2024 · 2 comments
Open

GitHub Actions workflows use deprecated/outdated actions #132

esabol opened this issue Oct 15, 2024 · 2 comments

Comments

@esabol
Copy link
Contributor

esabol commented Oct 15, 2024

The Actions tab shows the following warning:

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

https://github.com/actions/upload-artifact says:

actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024. Learn more. Similarly, v1/v2 are scheduled for deprecation on June 30, 2024. Please update your workflow to use v4 of the artifact actions. This deprecation will not impact any existing versions of GitHub Enterprise Server being used by customers.

So I think uses: actions/upload-artifact@v3 should be changed to uses: actions/upload-artifact@v4 in .github/workflows/build-and-check.yml.

So I thought I'd check the actions used in .github/workflows/deploy-docs.yml as well. Although not deprecated, actions/upload-pages-artifact is up to v3, and actions/deploy-pages is up to v4, but I'm not sure it's worth updating those?

https://github.com/actions/upload-pages-artifact?tab=readme-ov-file

https://github.com/actions/deploy-pages?tab=readme-ov-file

@esabol
Copy link
Contributor Author

esabol commented Oct 16, 2024

OK, taken care of actions/upload-artifact in .github/workflows/build-and-check.yml.

Shall I update the actions in .github/workflows/deploy-docs.yml also or just leave it alone since it's working fine and there aren't any deprecation warnings for those?

@vitcpp
Copy link
Contributor

vitcpp commented Oct 16, 2024

@esabol I can't say for sure about deploy-docs.yml. I'm not so experienced in the github actions stuff. Sometimes I try to learn it, but it seems I'm at the beginning of my long road to the understanding of the actions :) If you think to update the .yml file, I think it is ok to try. It doesn't affect the code. We can rollback it if something go in a wrong way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants