Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tf.function parameters #139

Open
khatchad opened this issue Jan 23, 2023 · 2 comments · May be fixed by #142
Open

Missing tf.function parameters #139

khatchad opened this issue Jan 23, 2023 · 2 comments · May be fixed by #142
Assignees
@tatianacv

Comments

@khatchad
Copy link
Member

Hybridize-Functions-Refactoring/edu.cuny.hunter.hybridize.tests/test cases/edu/cuny/hunter/hybridize/tests/HybridizeFunctionRefactoringTest.java

Lines 733 to 735 in cd6694c

assertTrue(!args.hasInputSignatureParam() && !args.hasAutoGraphParam() && !args.hasJitCompileParam()
&& !args.hasReduceRetracingParam() && !args.hasExperimentalImplementsParam() && !args.hasExperimentalAutographOptParam()
&& !args.hasExperimentalFollowTypeHintsParam() && !args.hasFuncParam());

According to https://www.tensorflow.org/versions/r2.9/api_docs/python/tf/function, we are missing:

  1. experimental_relax_shapes
  2. experimental_compile
@tatianacv
Copy link
Member

Since those are deprecated and have the same functionalities of jit_compile and reduce_retracing we are reusing the variables.

Hybridize-Functions-Refactoring/edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/analysis/Function.java

Lines 145 to 154 in cd6694c

else if (name.id.equals(JIT_COMPILE) || name.id.equals(EXPERIMENTAL_COMPILE))
// Found parameter jit_compile/experimental_compile
this.jitCompileParamExists = true;
// The version of the API we are using allows
// parameter names reduce_retracing
// and deprecated name experimental_relax_shapes
else if (name.id.equals(REDUCE_RETRACING) || name.id.equals(EXPERIMENTAL_RELAX_SHAPES))
// Found parameter reduce_retracing
// or experimental_relax_shapes
this.reduceRetracingParamExists = true;

@tatianacv tatianacv linked a pull request Jan 24, 2023 that will close this issue
Open
15 tasks
@khatchad
Copy link
Member Author

@tatianacv What is the status of this one? It seems like a very simply change that is taking a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tatianacv tatianacv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing tf.function parameters tatianacv/Hybridize-Functions-Refactoring
2 participants
@khatchad @tatianacv