Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible do_not_annotate changes #100

Open
kimrutherford opened this issue Oct 12, 2023 · 3 comments
Open

Possible do_not_annotate changes #100

kimrutherford opened this issue Oct 12, 2023 · 3 comments
Assignees

Comments

@kimrutherford
Copy link
Member

We should keep an eye on this issue:

because we might need to update our configuration if there are GO changes.

@kimrutherford kimrutherford self-assigned this Oct 12, 2023
@ValWood
Copy link
Member

ValWood commented Oct 13, 2023

Yes it isn't so urgent becasuse we rarely use the do not annotate term (usually we suggest them), and also I would pick them up via the GO logs.

We need to decide on the best messaging because sometimes people will want to 'park' at a 'do not annotate' term and suggest a new term, so we might not want to prevent it.
So far, I don't think any of the community have ever used a 'do not annotate'

@kimrutherford
Copy link
Member Author

So far, I don't think any of the community have ever used a 'do not annotate'

That's not possible in Canto due to the do_not_annotate flags in GO. If the names or meanings change we'll need to change the Canto config.

@ValWood
Copy link
Member

ValWood commented Oct 16, 2023

I think it's proba bly OK, it is all terms they shouldn't be using.
I'll keep an eye on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants