Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort accounts #1000

Open
xlc opened this issue Feb 14, 2022 · 4 comments
Open

Sort accounts #1000

xlc opened this issue Feb 14, 2022 · 4 comments
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. Enhancement Improves existing features or performance, making the SDK more robust and efficient. Help Wanted Tasks open for external contributions, suitable for independent or collaborative work. P4 - Needs Investigation Requires analysis to determine cause or feasibility. Not fully understood, needs research first.

Comments

@xlc
Copy link

xlc commented Feb 14, 2022

Currently the account order is mystery to me, change the chain will have it jump to some unexpected position.

If will be helpful if the order is something more user friendly. e.g. sort by: account hidden, network, the account name.

@jacogr
Copy link
Member

jacogr commented Feb 14, 2022

It is actually sorted, https://github.com/polkadot-js/extension/blob/master/packages/extension-ui/src/util/buildHierarchy.ts#L65-L76

  • network
  • name, path, creation

There is something to be said for defining your own oder, but in reality it will have to wait a long time

@xlc
Copy link
Author

xlc commented Feb 14, 2022

Screen Shot 2022-02-14 at 9 08 50 PM

It doesn't seems working for me.

@jacogr
Copy link
Member

jacogr commented Feb 14, 2022

Weird. That is completely random as depicted. (Not sure what goes weird, since I have not seen that, but pictures don’t lie)

@jacogr jacogr added -size-s Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. labels Feb 14, 2022
@qqqzhch
Copy link

qqqzhch commented Jan 29, 2023

Different networks have different formats of addresses.
Use these to sort them, the order is easy to change
network
name, path, creation
If have record the time when creating or importing account, account can be sort by time so that the order does not change easily.

Maybe just sorting by time would be fine, sorting by network and name would be easy to change due to switching networks

@TarikGul TarikGul added P4 - Needs Investigation Requires analysis to determine cause or feasibility. Not fully understood, needs research first. Enhancement Improves existing features or performance, making the SDK more robust and efficient. Help Wanted Tasks open for external contributions, suitable for independent or collaborative work. and removed needs investigation labels Oct 30, 2024
@TarikGul TarikGul moved this to P4 - Needs Investigation in Polkadot-js general project board Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. Enhancement Improves existing features or performance, making the SDK more robust and efficient. Help Wanted Tasks open for external contributions, suitable for independent or collaborative work. P4 - Needs Investigation Requires analysis to determine cause or feasibility. Not fully understood, needs research first.
Projects
Status: P4 - Needs Investigation
Development

No branches or pull requests

6 participants
@xlc @jacogr @qqqzhch @TarikGul and others