Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Hubs: switch over to paying fees using auto-swaps #475

Open
acatangiu opened this issue Oct 14, 2024 · 1 comment · May be fixed by #502
Open

Asset Hubs: switch over to paying fees using auto-swaps #475

acatangiu opened this issue Oct 14, 2024 · 1 comment · May be fixed by #502

Comments

@acatangiu
Copy link
Contributor

TakeFirstAssetTrader is still being used on Asset Hubs. This should be removed and rely solely on SwapFirstAssetTrader for paying fees with other assets than DOT/KSM.

TakeFirstAssetTrader was meant as a temporary solution until we have SwapFirstAssetTrader working and live swap pools with popular assets. The conditions are now right to remove TakeFirstAssetTrader.

The motivation to remove TakeFirstAssetTrader is that it doesn't (and can't) correctly account the economic value of weight. Depending on market movements, buying weight with sufficient assets can be abused to potentially severely undercut fees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants