Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PoV reclaim in all system chains #494

Open
kianenigma opened this issue Oct 24, 2024 · 3 comments
Open

Enable PoV reclaim in all system chains #494

kianenigma opened this issue Oct 24, 2024 · 3 comments

Comments

@kianenigma
Copy link
Contributor

as described in https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/guides/enable_pov_reclaim/index.html

@ggwpez
Copy link
Member

ggwpez commented Oct 24, 2024

@skunert do you think we can go ahead with this, or is something missing?

@skunert
Copy link
Contributor

skunert commented Oct 24, 2024

At this time I think our proof weight story is not as accurate as we would like it to be.

These issues lead to inaccuracies but we have safeguards in place to prevent overshooting the limits:

  1. Collators are still using pov_limit / 2 as the client-side size limit
  2. StorageWeightReclaim: set to node pov size if higher paritytech/polkadot-sdk#5281

However, these are workarounds while we have the proper fixes in progress. I expect the situation to get a lot better in the next releases, so if we can we should hold off a bit longer.

@kianenigma
Copy link
Contributor Author

Thanks for the update @skunert

This is not super time critical, but we probably want it in place before the AHM is done.

@seadanda short term, I highly suggest using PoV reclaim + its workarounds in ah-next runtime that you are working on, so that we can more accurately experiment with the throughput empirically.

pandres95 added a commit to pandres95/runtimes that referenced this issue Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants