Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: why build only debug and not release? #53

Open
cremesk opened this issue Jul 24, 2021 · 4 comments
Open

suggestion: why build only debug and not release? #53

cremesk opened this issue Jul 24, 2021 · 4 comments

Comments

@cremesk
Copy link

cremesk commented Jul 24, 2021

hi,
a suggestion... could we please build the plugin as a "release"?

I am building for a shared user system so am concerned with size and performance for the users who do not need debug.

the different is the plugin is so much small with cargo build --release. (more then 300M!)

cargo build:

12:19:40 [email protected] ~/ la /home/creme/.weechat/plugins
.rw-r--r-- 338M creme envs 24 Jul 10:10 matrix.so

and
cargo build --release:

15:24:14 [email protected] ~/ la /home/creme/.weechat/plugins
.rw-r--r-- 25M creme envs 24 Jul 13:24 matrix.so
@poljar
Copy link
Owner

poljar commented Jul 30, 2021

We aren't building the plugin anywhere? Users can chose how they would like to build it.

Well we are now with every push, but that indeed uses release mode.

@cremesk
Copy link
Author

cremesk commented Jul 30, 2021

it is not built anywhere but in the readme.md i only read about a cargo build.

for someone who is not compliant with this it is not obvious that there is a release mode.

https://github.com/poljar/weechat-matrix-rs/blame/master/README.md#L28

@poljar
Copy link
Owner

poljar commented Jul 30, 2021

I guess we can switch the README to tell people to build using --release.

@cremesk
Copy link
Author

cremesk commented Jul 30, 2021

i think it would be convenient for the "default" user.

you can create a part. "Development" in the readme where the debug mode is used for building.
but i guess developers already know that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants